Skip to content

Feature/qraffle#809

Merged
Franziska-Mueller merged 5 commits intoqubic:developfrom
double-k-3033:feature/qraffle
Apr 20, 2026
Merged

Feature/qraffle#809
Franziska-Mueller merged 5 commits intoqubic:developfrom
double-k-3033:feature/qraffle

Conversation

@double-k-3033
Copy link
Copy Markdown
Contributor

@double-k-3033 double-k-3033 commented Mar 26, 2026

cyber-pc
cyber-pc approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cyber-pc cyber-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I have reviewed the parameter arithmetic only — fee percentages sum correctly (20% total unchanged), register amount value matches the PR description. I have not reviewed the business logic, fund safety, or legal/regulatory compliance of this contract. Ensuring correctness and compliance is the responsibility of the contract team.

@double-k-3033
Copy link
Copy Markdown
Contributor Author

double-k-3033 commented Mar 30, 2026

You are right. Our team is currently undergoing a smart contract audit and is nearing completion.

@Franziska-Mueller Franziska-Mueller mentioned this pull request Apr 8, 2026
Closed
@Franziska-Mueller
Copy link
Copy Markdown
Collaborator

Franziska-Mueller commented Apr 13, 2026

Closing this one because all changes are contained in #823

@double-k-3033
Copy link
Copy Markdown
Contributor Author

double-k-3033 commented Apr 16, 2026 •
edited
Loading

Closing this one because all changes are contained in #823

Hi, @Franziska-Mueller.
Sorry for my busy and bad.
We are going to work on #823. and reopen it when ready.
Plz reopen #809 and merge it into develop branch because @cyber-pc already approved about #809. I closed #823 PR.
I hope that #809 is merged into the main branch in next epoch.
shareholders are waiting for 809 to be committed

@Franziska-Mueller
Copy link
Copy Markdown
Collaborator

Franziska-Mueller commented Apr 17, 2026

@double-k-3033 please point me to a poll where the change of the QXMR logout fee was approved. I can only find votes for the shareholder/burn change and the increase of the registration fee.

@double-k-3033
Copy link
Copy Markdown
Contributor Author

double-k-3033 commented Apr 17, 2026 •
edited
Loading

@double-k-3033 please point me to a poll where the change of the QXMR logout fee was approved. I can only find votes for the shareholder/burn change and the increase of the registration fee.

Let me see.
From the beginning of project, the logout fee has been 5%. So increasing the register fee, would increase logout fee.
We increased Register fee from 100M to 250M. So We increased logout fee from 5M to 12.5M.

https://github.com/qubic/proposal/blob/6b049f7fcf855d18a16b248486dd8d9b458548d6/SmartContracts/2025-12-01-QRaffle.md

Franziska-Mueller
Franziska-Mueller reviewed Apr 17, 2026
View reviewed changes
Comment thread src/contracts/QRaffle.h Outdated
@Franziska-Mueller Franziska-Mueller merged commit 3cbf53d into qubic:develop Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Franziska-Mueller Franziska-Mueller Franziska-Mueller approved these changes

@cyber-pc cyber-pc cyber-pc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@double-k-3033 @Franziska-Mueller @cyber-pc